fix(email-connector): send emails will always make the process fail #3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnBgood
approved these changes
Sep 30, 2024
mathias-vandaele
deleted the
send-email-should-always-fail-when-throwing
branch
|
Successfully created backport PR for |
mathias-vandaele
added a commit
that referenced
this pull request
Sep 30, 2024
…3394) (#3395) (cherry picked from commit 91ce206) Co-authored-by: Mathias Vandaele <[email protected]>
mathias-vandaele
added a commit
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick fix, the send email action will always fails if the mail cannot be sent
Related issues
closes #
Checklist
no milestonelabel.