Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sqs): remove pattern validation in runtime, add override description to template #3366

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix(sqs): remove pattern validation in runtime, add override description to template #3366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06d4ac1
fix(sqs): add last minute fix (discussed with the team)
mathias-vandaele Sep 27, 2024
3085fb4
docs(readme): fix Spotless formatting issues
ev-codes Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions connectors/aws/aws-sqs/element-templates/aws-sqs-boundary-connector.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,13 @@
}, {
ev-codes marked this conversation as resolved.
Show resolved Hide resolved
"id" : "queue.queue.pollingWaitTime",
"label" : "Polling wait time",
"description" : "The duration (in seconds) for which the call waits for a message to arrive in the queue before returning. See <a href=\"https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/amazon-sqs/?amazonsqs=inbound\" target=\"_blank\">documentation</a> for details",
"description" : "The duration (in seconds) for which the call waits for a message to arrive in the queue before returning. See <a href=\"https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/amazon-sqs/?amazonsqs=inbound\" target=\"_blank\">documentation</a> for details. A value of 0 will automatically be overridden to 1",
"optional" : false,
"value" : "20",
"constraints" : {
"notEmpty" : true,
"pattern" : {
"value" : "^([1-9]?|1[0-9]|20|secrets\\..+)$"
"value" : "^([0-9]?|1[0-9]|20|secrets\\..+)$"
}
},
"group" : "messagePollingProperties",
Expand Down
4 changes: 2 additions & 2 deletions connectors/aws/aws-sqs/element-templates/aws-sqs-inbound-intermediate-connector.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,13 @@
}, {
"id" : "queue.queue.pollingWaitTime",
"label" : "Polling wait time",
"description" : "The duration (in seconds) for which the call waits for a message to arrive in the queue before returning. See <a href=\"https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/amazon-sqs/?amazonsqs=inbound\" target=\"_blank\">documentation</a> for details",
"description" : "The duration (in seconds) for which the call waits for a message to arrive in the queue before returning. See <a href=\"https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/amazon-sqs/?amazonsqs=inbound\" target=\"_blank\">documentation</a> for details. A value of 0 will automatically be overridden to 1",
"optional" : false,
"value" : "20",
"constraints" : {
"notEmpty" : true,
"pattern" : {
"value" : "^([1-9]?|1[0-9]|20|secrets\\..+)$"
"value" : "^([0-9]?|1[0-9]|20|secrets\\..+)$"
}
},
"group" : "messagePollingProperties",
Expand Down
4 changes: 2 additions & 2 deletions connectors/aws/aws-sqs/element-templates/aws-sqs-start-message.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,13 @@
}, {
"id" : "queue.queue.pollingWaitTime",
"label" : "Polling wait time",
"description" : "The duration (in seconds) for which the call waits for a message to arrive in the queue before returning. See <a href=\"https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/amazon-sqs/?amazonsqs=inbound\" target=\"_blank\">documentation</a> for details",
"description" : "The duration (in seconds) for which the call waits for a message to arrive in the queue before returning. See <a href=\"https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/amazon-sqs/?amazonsqs=inbound\" target=\"_blank\">documentation</a> for details. A value of 0 will automatically be overridden to 1",
ev-codes marked this conversation as resolved.
Show resolved Hide resolved
"optional" : false,
"value" : "20",
"constraints" : {
"notEmpty" : true,
"pattern" : {
"value" : "^([1-9]?|1[0-9]|20|secrets\\..+)$"
"value" : "^([0-9]?|1[0-9]|20|secrets\\..+)$"
}
},
"group" : "messagePollingProperties",
Expand Down
4 changes: 2 additions & 2 deletions ...s/aws-sqs/src/main/java/io/camunda/connector/inbound/model/SqsInboundQueueProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ public record SqsInboundQueueProperties(
group = "messagePollingProperties",
defaultValue = "20",
description =
"The duration (in seconds) for which the call waits for a message to arrive in the queue before returning. See <a href=\"https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/amazon-sqs/?amazonsqs=inbound\" target=\"_blank\">documentation</a> for details",
"The duration (in seconds) for which the call waits for a message to arrive in the queue before returning. See <a href=\"https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/amazon-sqs/?amazonsqs=inbound\" target=\"_blank\">documentation</a> for details. A value of 0 will automatically be overridden to 1",
feel = FeelMode.disabled)
@Pattern(regexp = "^([1-9]?|1[0-9]|20|secrets\\..+)$")
@Pattern(regexp = "^([0-9]?|1[0-9]|20|secrets\\..+)$")
@NotBlank
String pollingWaitTime) {}
Loading