feat: support migration mapping for error event sub processes #23850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component/operate
pedesen
force-pushed
the
fe-23804-migrate-error-elements
branch
from
25a4d3c
to
03e57b4
Compare
pedesen
force-pushed
the
fe-23804-migrate-error-elements
branch
from
03e57b4
to
7e51f54
Compare
pedesen
commented
Oct 23, 2024
Comment on lines
+718
to
+735
| /** | ||
| * Business rule task | ||
| */ | ||
| await processInstancePage.diagram.clickFlowNode('Business rule task 2'); | ||
| await processInstancePage.diagram.showMetaData(); | ||
|
|
||
| /** | ||
| * Expect that the incident for the business rule task has been migrated. | ||
| * The target task "Business rule task 2" has a different called decision "invalid2" | ||
| * which is expected to be overwritten with the decision key "invalid". | ||
| */ | ||
| await expect( | ||
| processInstancePage.metadataModal.getByText( | ||
| "Expected to evaluate decision 'invalid', but no decision found for id 'invalid'", | ||
| ), |
There was a problem hiding this comment.
I just moved this to the end of the tests, since it caused some issues when it was executed first.
Comment on lines
+663
to
+677
| * Expect that the script task incident has been migrated. | ||
| * The target task "Script task 2" has a FEEL expression which would be | ||
| * evaluated immediately which is expected to be overwritten with the incident. | ||
| */ | ||
| await expect( | ||
| processInstancePage.metadataModal.getByText( | ||
| "Expected to evaluate decision 'invalid', but no decision found for id 'invalid'", | ||
| ), | ||
| processInstancePage.metadataModal.getByText('expected worker failure'), | ||
| ).toBeVisible(); | ||
|
|
||
| await processInstancePage.metadataModal | ||
| .getByRole('button', {name: /close/i}) | ||
| .click(); | ||
| await processInstancePage.diagram.clickFlowNode('Script task 2'); // deselect Script task 2 |
There was a problem hiding this comment.
I just moved the business rule section to the end of the tests, nothing else was changed related to script task or business rule task
Comment on lines
+697
to
+719
| * Task G | ||
| */ | ||
| await processInstancePage.diagram.clickFlowNode('Send task 2'); | ||
| await processInstancePage.diagram.clickFlowNode('Task G'); | ||
| await processInstancePage.diagram.showMetaData(); | ||
|
|
||
| /** | ||
| * Expect that the active send task with task worker "foo" has been migrated. | ||
| * The target task "Send task 2" has the task type "failingTaskWorker", which would | ||
| * end up in an incident state. This is expected to be overwritten with the "foo" worker type. | ||
| * Expect that Task G has been migrated. The target Task G is following an error event "error2" | ||
| * which is never thrown. Without a successful migration Task G would not be active. | ||
| */ | ||
| await expect( | ||
| processInstancePage.metadataModal.getByText('expected worker failure'), | ||
| processInstancePage.metadataModal.getByText('endDate'), | ||
| ).toBeVisible(); | ||
| await expect( | ||
| processInstancePage.metadataModal.getByText('"endDate": "null"'), | ||
| ).not.toBeVisible(); | ||
|
|
||
| await processInstancePage.metadataModal | ||
| .getByRole('button', {name: /close/i}) | ||
| .click(); | ||
| await processInstancePage.diagram.clickFlowNode('Task G'); // deselect Script task 2 |
There was a problem hiding this comment.
The part related to Task G was added.
| @@ -60,6 +60,7 @@ | |||
| <bpmn:outgoing>Flow_1eim29b</bpmn:outgoing> | |||
| <bpmn:outgoing>Flow_08q3qdg</bpmn:outgoing> | |||
| <bpmn:outgoing>Flow_17wkkw8</bpmn:outgoing> | |||
| <bpmn:outgoing>Flow_13sckg7</bpmn:outgoing> | |||
There was a problem hiding this comment.
Diff: Error event sub process was moved inside a sub process to isolate the error handling.
| @@ -118,6 +118,7 @@ | |||
| <bpmn:outgoing>Flow_1w3h29f</bpmn:outgoing> | |||
| <bpmn:outgoing>Flow_1lx7h0o</bpmn:outgoing> | |||
| <bpmn:outgoing>Flow_1ggtty0</bpmn:outgoing> | |||
| <bpmn:outgoing>Flow_030xtpk</bpmn:outgoing> | |||
There was a problem hiding this comment.
Diff: error event sub process was added:
| @@ -145,6 +145,7 @@ | |||
| <bpmn:outgoing>Flow_1ixacpg</bpmn:outgoing> | |||
| <bpmn:outgoing>Flow_0796mcu</bpmn:outgoing> | |||
| <bpmn:outgoing>Flow_0t0hay3</bpmn:outgoing> | |||
| <bpmn:outgoing>Flow_0hc14mk</bpmn:outgoing> | |||
There was a problem hiding this comment.
Diff: error event sub process was added:
vitorwtavares
approved these changes
Oct 23, 2024
|
@Szik Please test with this image: |
Szik
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Related issues
closes #23804