Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform): Update to 8.3.0-alpha4 #263

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Conversation

megglos
Copy link
Contributor

@megglos megglos commented Aug 8, 2023

No description provided.

@megglos megglos force-pushed the meg-release-830-alpha4 branch from 5b58308 to 7172e18 Compare August 8, 2023 05:07
curl got removed from the zeebe image and not better alternative available
@megglos megglos force-pushed the meg-release-830-alpha4 branch from 98c4c7a to 9e4152a Compare August 8, 2023 07:01
@megglos
Copy link
Contributor Author

megglos commented Aug 8, 2023

@jessesimpson36 @npepinpe since camunda/camunda#13706 we don't have curl available in the zeebe dist anymore, as also there is no wget I went for a plain tcp check as health indicator for now 9e4152a

stable branches of this repo are not affected as they have no healtcheck :D

Do you see any better alternatives?

@megglos
Copy link
Contributor Author

megglos commented Aug 8, 2023

will merge for now to unblock the alpha release but let's follow-up on this

@megglos megglos merged commit 22c13dc into main Aug 8, 2023
@megglos megglos deleted the meg-release-830-alpha4 branch August 8, 2023 07:10
@jessesimpson36
Copy link
Contributor

I've never seen this :> operator, but if the healthcheck works, then I have no issues! I mean, unless we're on an image that has bash compiled without support for network redirections ( the feature that /dev/tcp/host/port uses).

Also, I may have backported healthchecks to the stable branches. 😅

@megglos
Copy link
Contributor Author

megglos commented Aug 12, 2023

Also, I may have backported healthchecks to the stable branches. 😅

At least on stable/8.2 there are no health checks, now I checked 8.1 an there they are 😅 but 8.1 still has curl with the current patch, will fail next time we update then ^^

@jessesimpson36
Copy link
Contributor

That's so strange. there should be healthchecks on all of them. Sometimes github does some merge-conflict resolution, and I'm wondering if the healthcheck change didn't make it. I'd like to add the healthchecks back in to each stable branch (8.1 and 8.2).

A minor concern I have is that some components are looking to switch to using alpine, which I think might break the :> /dev/tcp redirection

I'll try to get to this soon, but not when I have as many tickets as I'm currently dealing with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants