Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding schema.json file to alpha version #2537

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hamza-m-masood
Copy link
Contributor

Which problem does the PR fix?

closes: #2536

What's in this PR?

The readme-generator fails to generate a schema if any value is left empty. So, I added empty strings to each value that was left empty.
here is how you can generate a schema using the readme-generator command:

❯ readme-generator \
--values "./values.yaml" \
--readme "./README.md" \
--schema "./schema.json"

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@hamza-m-masood
Copy link
Contributor Author

@aabouzaid I'm not sure what to do about the sensible defaults on the podDisruptionBudget. What do you think is the best solution here?

Other than empty strings, here are all the sensible defaults I've made: f437894

@hamza-m-masood
Copy link
Contributor Author

hamza-m-masood commented Nov 7, 2024

The unit test called TestExistingSecretConstraintDoesNotDisplayErrorForComponentWithExistingSecret is failing in test/unit/camunda I am unsure how to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set the schema types for Helm chart 8.7
1 participant