fix: set optimize global elasticsearch prefix #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanlukas
changed the title
jonathanlukas
changed the title
aabouzaid
changed the title
aabouzaid
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Thanks @jonathanlukas 🙌
Could you please make the fix for all chart versions? (the current fix is for 8.5 only)
|
@aabouzaid done for 8.3, 8.4, 8.5, 8.6, alpha and latest. For 8.2, the property |
RomanJRW
approved these changes
Oct 21, 2024
aabouzaid
force-pushed
the
jonathanlukas-patch-2
branch
from
c3252c1
to
bc7a737
Compare
aabouzaid
requested review from
drodriguez-305
and removed request for
aabouzaid
jonathanlukas
force-pushed
the
jonathanlukas-patch-2
branch
from
bc7a737
to
20b9cf9
Compare
|
@drodriguez-305 now takes care of reviewing this task. |
drodriguez-305
force-pushed
the
jonathanlukas-patch-2
branch
from
b8994de
to
a9e8c4b
Compare
drodriguez-305
approved these changes
Oct 30, 2024
github-actions
bot
added
version/8.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
Optimize does not respect the
global.elasticsearch.prefix, so this setting has to be adjusted manually.What's in this PR?
respect the elasticsearch prefix in the environment-config.yaml
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only.After opening the PR: