-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add camunda exporter support to zeebe #2476
feat: add camunda exporter support to zeebe #2476
Conversation
@aabouzaid I just did a first iteration which follows the structure of the other exporters as found here elasticsearch exporter config. I am also passing any config available for elasticsearch or opensearch. |
@drodriguez-305 LGTM 👍 |
@aabouzaid at first we noticed that the url was added with an extra line. After fixing the url template rendering issue, I am still encountering getting an error in zeebe. @mustafadagher can you confirm if there is anything that might be missing?
Confirmed by checking the configmap and it seems to be rendering the url correctly into the camunda exporter.
|
@drodriguez-305 to me, the configuration you posted looks correct. but I'm not sure if there might be wrong indentation or something that causes the url not to be read! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's just wait for the CI to finish before we merge.
0c26033
to
deff5da
Compare
Which problem does the PR fix?
Related to #2294
What's in this PR?
Adding support for the new camunda exporter.
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only
.After opening the PR: