Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support optional chart secrets auto-generation - Camunda 8.6 #2257

Merged
merged 1 commit into from
Sep 2, 2024
Merged

feat: support optional chart secrets auto-generation - Camunda 8.6 #2257

merged 1 commit into from
Sep 2, 2024

Conversation

aabouzaid
Copy link
Member

@aabouzaid aabouzaid commented Aug 23, 2024 •
edited
Loading

Which problem does the PR fix?

Task: #1983

What's in this PR?

  • Add option to auto-generate secretes once at the installation time and keep them out of chart upgrades using Helm hooks.
  • Support auto-generated secrets in the Distro GHA and enable it for the Camunda 8.6 chart.
  • Support customizing test suites job so we can set different vars for each Camund chart version.
  • Support customizing secret keys.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@aabouzaid aabouzaid self-assigned this Aug 23, 2024
@aabouzaid aabouzaid force-pushed the 1983-aa-auto-generate-chart-secrets branch from 2b413f8 to b4b078e Compare August 23, 2024 14:27
@aabouzaid aabouzaid force-pushed the 1983-aa-auto-generate-chart-secrets branch from b4b078e to c9001b1 Compare August 23, 2024 15:00
@aabouzaid aabouzaid mentioned this pull request Aug 23, 2024
Closed
@aabouzaid aabouzaid force-pushed the 1983-aa-auto-generate-chart-secrets branch 5 times, most recently from 94545f0 to f42b915 Compare August 23, 2024 22:18
@aabouzaid aabouzaid force-pushed the 1983-aa-auto-generate-chart-secrets branch 7 times, most recently from f60440f to e1b32f9 Compare August 24, 2024 01:25
@aabouzaid aabouzaid added the test-persistent Don't delete the Helm deployment created by the PR and use fixed names label Aug 24, 2024
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2257-intg-8-2 September 2, 2024 19:05 Destroyed
@aabouzaid aabouzaid force-pushed the 1983-aa-auto-generate-chart-secrets branch 2 times, most recently from bcb1169 to b17ebbe Compare September 2, 2024 19:16
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2257-intg-8-2-upgrade September 2, 2024 19:23 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2257-intg-8-3-upgrade September 2, 2024 19:23 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2257-intg-8-4-upgrade September 2, 2024 19:23 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2257-intg-8-2 September 2, 2024 19:23 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2257-intg-8-3 September 2, 2024 19:23 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-2257-intg-8-4 September 2, 2024 19:23 Destroyed
@aabouzaid aabouzaid force-pushed the 1983-aa-auto-generate-chart-secrets branch 2 times, most recently from a586994 to d875660 Compare September 2, 2024 19:55
@aabouzaid aabouzaid marked this pull request as ready for review September 2, 2024 21:35
@aabouzaid aabouzaid requested a review from a team September 2, 2024 21:35
@aabouzaid aabouzaid force-pushed the 1983-aa-auto-generate-chart-secrets branch from d875660 to 994a144 Compare September 2, 2024 21:39
@aabouzaid aabouzaid removed the test-persistent Don't delete the Helm deployment created by the PR and use fixed names label Sep 2, 2024
@aabouzaid aabouzaid force-pushed the 1983-aa-auto-generate-chart-secrets branch from 994a144 to 87d6d49 Compare September 2, 2024 21:40
@aabouzaid aabouzaid merged commit 37085aa into main Sep 2, 2024
28 of 30 checks passed
@aabouzaid aabouzaid deleted the 1983-aa-auto-generate-chart-secrets branch September 2, 2024 21:51
@distro-ci distro-ci bot mentioned this pull request Sep 2, 2024
Merged
@aabouzaid aabouzaid changed the title feat: support optional chart secrets auto-generation feat: support optional chart secrets auto-generation - Camunda 8.6 Sep 3, 2024
@aabouzaid aabouzaid added the size/m Relative effort/time: Medium label Sep 3, 2024
@hamza-m-masood hamza-m-masood added the version:10.4.0 Issues and PRs related to chart version 10.4.0 label Sep 9, 2024
@aabouzaid aabouzaid added the version/8.5 Camunda applications/cycle version label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aabouzaid aabouzaid

Labels
component/connectors component/console component/identity component/operate component/optimize component/tasklist component/web-modeler component/zeebe kind/enhancement New feature or request size/m Relative effort/time: Medium tool/github-actions version/8.5 Camunda applications/cycle version version:10.4.0 Issues and PRs related to chart version 10.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aabouzaid @hamza-m-masood