-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable connector templates per default #4474
Conversation
bbd08dc
to
d29a2e1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
34c5855
to
72bd1cc
Compare
I've tested this and it works fine. There's only one issue on MacOS which was probably introduced with the feature (not this PR). When I close the window while the templates are being fetched, there's an unhandled error in the log:
It's non-critical though. |
Related to this I've seen the issue previously. We should be fail-safe and not fail when sending messages to non-existing main windows. |
29d2c13
to
4e3eaf3
Compare
Ensure we don't fail with an app error once the main window is closed. Related to #4474 (comment)
With 7dc67f4 we'll now log a warning to the console, and not attempt to send the message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
CC @philippfromme as you worked on this previously. |
Ensure we only update the templates if an active C8 tab is opened.
Ensure we don't fail with an app error once the main window is closed. Related to #4474 (comment)
7dc67f4
to
d9f7c5b
Compare
* @param {string} userPath | ||
*/ | ||
function registerConnectorTemplateUpdater(renderer, userPath) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👏🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 💪🏻
Proposed Changes
Implements #4455, specifically:
activeTab.changed
in the appenable-connector-templates=true
is the defaultCloses #4455
Related to camunda/camunda-docs#4187
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}