Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not propagate events handled by keyboard bindings #3095

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

philippfromme
Copy link
Contributor

Temporary fix until bpmn-io/bpmn-js-properties-panel#739 arrives.


Closes #3016

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Aug 17, 2022
@github-actions
Copy link

This Pull Request targets develop branch, but contains fix commits.

Consider targeting master instead.

@philippfromme philippfromme changed the base branch from develop to master August 17, 2022 09:23
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Aug 17, 2022
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem to fail, please have a look.

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@philippfromme philippfromme merged commit 3ce535d into master Aug 18, 2022
@philippfromme philippfromme deleted the 3016-keyboard-fix branch August 18, 2022 07:37
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Aug 18, 2022
@pinussilvestrus pinussilvestrus added this to the M56 milestone Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undo removes multiple execution listeners at a time
3 participants