Template selector is misplaced

[nikku]

Describe the bug

The template selection is misplaced (very low in the properties panel), so that it can easily be overlooked:

Steps to reproduce

1. Open any diagram
2. Model any task
3. Locate template picker -> very low in the properties panel

Expected behavior

Template picker is prominently displayed in the properties panel, below the "Documentation" section.

Environment

• OS: Any
• Camunda Modeler Version: v5.28.0
• Execution Platform: Camunda 8
• Installed plug-ins: None

Additional context

No response

[barmac]

Let's clarify:

Template picker is prominently displayed in the properties panel.

So below documentation like in 5.25:

[barmac]

This needs to be fixed in https://github.com/bpmn-io/bpmn-js-element-templates/blob/main/src/cloud-element-templates/properties-panel/ElementTemplatesPropertiesProvider.js#L61

[barmac]

We still want to display the execution listeners above the template when it's applied, correct?

[barmac]

Example:

[misiekhardcore]

I think this needs to be fixed in bpmn-js-properties-panel as well, so the Zeebe_ExecutionListener group is also above the other groups. Otherwise if Zeebe_ExecutionListener is down on the list, and we put Templates below, those two will always be on the bottom

[nikku]

@misiekhardcore Where else could we anchor the element template selector, so we don't have to move Zeebe execution listeners?

[misiekhardcore]

Looking at @barmac comment above, we want to also move the execution listeners higher, currently the templates are after execution listeners and execution listeners are by themself low on the list

[nikku]

You mean this?

We still want to display the execution listeners above the template when it's applied, correct?

What would be practical reasons to put execution listeners above the template selector? I don't see it.

The way I see it: Template group is the group following the general section, potentially following the documentation section (documentation = general concern). Everything else follows below, in the natural order. Listeners are less often used than template properties themselves, and hence should go late in the list, above extension properties is a reasonable place when no template is selected, below the domain specific template fields when a template is selected.

[misiekhardcore]

sounds reasonable to me, I just tried to follow whats was written in the comments. If you are both fine with just moving the templates group right below the Documentation group, then I will do that

[barmac]

I moved the template group below execution listeners for a templated element to prevent conflating execution listeners with the template-specific properties. However, if we see the templated element as just one of the elements, then I agree that there should be no change in positioning. So it's OK to position the template group right below the documentation regardless if template is applied or not, and execution listeners group on the bottom.

[barmac]

We still want to display the execution listeners above the template when it's applied, correct?

So I take back this.

[nikku]

This issues is not closed by bpmn-io/bpmn-js-element-templates#130, but instead awaits integration of the upstream change to be fixed. I re-opened and attached fixed upstream to it.

[philippfromme]

Ooops, sorry I missed that it included a closes. Indeed it's only related to.