Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support collapsed subprocesses in C8 #4020

Closed
3 tasks done
CatalinaMoisuc opened this issue Dec 11, 2023 · 13 comments · Fixed by #4029
Closed
3 tasks done

Support collapsed subprocesses in C8 #4020

CatalinaMoisuc opened this issue Dec 11, 2023 · 13 comments · Fixed by #4029
Assignees
Labels
Camunda 8 Flags an issue as related to Camunda 8 enhancement New feature or request
Milestone

Comments

@CatalinaMoisuc
Copy link
Member

CatalinaMoisuc commented Dec 11, 2023

Implementation task for https://github.com/camunda/product-hub/issues/294.

Problem you would like to solve

Camunda 8 (target version pending) is going to support collapsed sub-processes. Our tool should reflect that.

Proposed solution

Enable support for collapsed subprocesses in C8:

  • Validation allows collapsed sub-processes for 8.4
  • Validation disallows collapsed sub-process with aligned message Only supported in 8.4 and newer for older Camunda versions.

Follow-up in Web Modeler:

Alternatives considered

None.

Additional context

We currently support modeling already, but mark the sub-process as "unsupported", using an outdated message:

image

@CatalinaMoisuc CatalinaMoisuc added the enhancement New feature or request label Dec 11, 2023
@nikku
Copy link
Member

nikku commented Dec 11, 2023

@CatalinaMoisuc I updated the issue. From what I see we still lack the target version.

@nikku nikku added Camunda 8 Flags an issue as related to Camunda 8 needs more information Requires additional information to be actionable. labels Dec 11, 2023
@CatalinaMoisuc
Copy link
Member Author

@nikku if I follow the discussions in PHub, it seems that there is no actual change needed in any of the other products, so to me it seems that the target can also be 8.4. if the timeline would work for us given the upcoming FTOs and early code-freeze.

@nikku
Copy link
Member

nikku commented Dec 11, 2023

Moving to ready in that case.

@nikku nikku added this to the M72 milestone Dec 11, 2023
@nikku nikku added the ready Ready to be worked on label Dec 11, 2023
@CatalinaMoisuc
Copy link
Member Author

CatalinaMoisuc commented Dec 11, 2023

@nikku We also had a quick chat on this in the last weekly and I think this can simply be enabled via camunda-bpmn-js also for C8 as is for C7 and no actual change will be necessary on the Web Modeler side other than integrating the dependency update. Is my assumption correct?

@nikku
Copy link
Member

nikku commented Dec 11, 2023

Yes. Cf. the additional details I added to the issue.

@CatalinaMoisuc
Copy link
Member Author

@barmac can you please give a heads-up to the Web team so they can enable it as well and update for the lint rule?

@nikku
Copy link
Member

nikku commented Dec 12, 2023

I updated the description, also flagging the follow-up needed in web modeler.

@CatalinaMoisuc
Copy link
Member Author

FYI, follow-up is needed not only because the plugin has to be removed, but we also have to shift the position of the overlay as it is overlapping with some other overlays we have.

@barmac
Copy link
Collaborator

barmac commented Dec 13, 2023

I will look into this tomorrow.

barmac added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Dec 14, 2023
@barmac barmac removed the needs more information Requires additional information to be actionable. label Dec 14, 2023
barmac added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Dec 14, 2023
barmac added a commit to camunda/linting that referenced this issue Dec 14, 2023
@barmac
Copy link
Collaborator

barmac commented Dec 14, 2023

@barmac barmac added the in progress Currently worked on label Dec 14, 2023 — with bpmn-io-tasks
@barmac barmac removed the ready Ready to be worked on label Dec 14, 2023
merge-me bot pushed a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Dec 14, 2023
barmac added a commit to camunda/linting that referenced this issue Dec 14, 2023
merge-me bot pushed a commit to camunda/linting that referenced this issue Dec 14, 2023
@barmac barmac added fixed upstream Requires integration of upstream change and removed in progress Currently worked on labels Dec 14, 2023
barmac added a commit that referenced this issue Dec 14, 2023
deps: update `@camunda/linting`

Closes #4020
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed fixed upstream Requires integration of upstream change labels Dec 14, 2023
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Dec 14, 2023
@HanselIdes
Copy link

HanselIdes commented Dec 14, 2023

This looks great for Modeler and Operate!

@crobbins215, one requirement may have been missed
In the PDP epic https://github.com/camunda/product-hub/issues/294#issuecomment-1835701940 I added a must-have requirement to explain the limitations in Optimize with collapsed subprocesses. I also added a user story: "As a Developer, I am warned that analysis of the collapsed sub-process is not supported in Optimize", and that hasn't been removed or implemented AFAIK. This could also be done through documentation, but it's your call.

@CatalinaMoisuc
Copy link
Member Author

I don't think we should use linting to tell the user that a feature is not supported in Optimize, collapsed subprocesses - what the user modeled is supported - @crobbins215 I would propose that we ask the Optimize team to document that.

@nikku
Copy link
Member

nikku commented Dec 15, 2023

@HanselIdes Let's keep scoping discussions on the PDP epic. I propose we're pragmatic here.

barmac added a commit that referenced this issue Dec 15, 2023
deps: update `@camunda/linting`

Closes #4020
nikku pushed a commit that referenced this issue Dec 15, 2023
deps: update `@camunda/linting`

Closes #4020
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Camunda 8 Flags an issue as related to Camunda 8 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants