-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Tab Error handling #1214
Comments
The reason why we don't handle errors gracefully is that |
We don't have to implement |
Suggestion: Find an icon to make someones day, if the editor fails, e.g. https://thenounproject.com/term/open-source/?search=error Caveat: We need to make sure we use free icons or provide proper attribution. |
Note: Enzyme does not support |
Is your feature request related to a problem? Please describe.
Tabs may throw errors and technically we got the
EditorTab
to handle errors gracefully and propagate them. Unfortunately triggering an actual error, e.g. by inserting a line such asinto a tab constructor, e.g. the
BpmnTab
is not properly handled and results in the app being unmounted.Describe the solution you'd like
Describe alternatives you've considered
None.
The text was updated successfully, but these errors were encountered: