Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add optimize translation diff #4390

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Conversation

misiekhardcore
Copy link
Contributor

@misiekhardcore misiekhardcore commented Oct 3, 2024

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Copy link
Contributor

github-actions bot commented Oct 3, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in optimize/. You might want to duplicate these changes in optimize_versioned_docs/version-3.13.0/.

  • optimize/self-managed/optimize-deployment/migration-update/camunda-7/3.13-to-3.14.md
  • optimize/self-managed/optimize-deployment/migration-update/camunda-8/3.13_8.5-to-8.6.md
  • optimize/self-managed/optimize-deployment/migration-update/translation-diffs/differences_localization_313_314.diff

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@misiekhardcore misiekhardcore added the 8.6.0 October 2024 minor release label Oct 3, 2024
@misiekhardcore misiekhardcore requested review from buccarel, grlimacan and a team October 3, 2024 10:29
grlimacan
grlimacan previously approved these changes Oct 3, 2024
Copy link
Contributor

@grlimacan grlimacan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mesellings mesellings requested review from mesellings and removed request for a team October 3, 2024 14:37
mesellings
mesellings previously approved these changes Oct 3, 2024
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍 (just one minor rewording suggestion for conciseness, but you do not need to incorporate)


[en.json.diff](../translation-diffs/differences_localization_313_314.diff)

- Lines with a `+` in the beginning mark the addition/update of a term; lines with a `-` mark the removal of a term.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Lines with a `+` in the beginning mark the addition/update of a term; lines with a `-` mark the removal of a term.
- Lines with a `+` in the beginning mark a term addition/update. Lines with a `-` mark a term removal.

Just a minor rewording suggestion, non-blocking 👍

@christinaausley christinaausley added component:optimize Issues related with Optimize project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed labels Oct 3, 2024
@misiekhardcore misiekhardcore requested review from grlimacan and mesellings and removed request for buccarel October 4, 2024 09:27
@misiekhardcore misiekhardcore enabled auto-merge (squash) October 4, 2024 09:28
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍 🚀

@misiekhardcore misiekhardcore merged commit faefaf6 into main Oct 4, 2024
9 checks passed
@misiekhardcore misiekhardcore deleted the optimize-update-docs branch October 4, 2024 15:03
christinaausley pushed a commit that referenced this pull request Oct 7, 2024
* chore: add optimize translation diff

* refactor: use different wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.6.0 October 2024 minor release component:optimize Issues related with Optimize project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants