-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: process instance pdk api enhancement #4847
Open
yanavasileva
wants to merge
55
commits into
master
Choose a base branch
from
fidelity-contributions-feature/git-issue-4049-process-instance-pdk-api-enhancement
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: process instance pdk api enhancement #4847
yanavasileva
wants to merge
55
commits into
master
from
fidelity-contributions-feature/git-issue-4049-process-instance-pdk-api-enhancement
+146
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID /Get Process Instance List /Post Process instance list to include Process definition key in the API response related to GIT Issue : 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
Process Instance API Enhancement with Process definition Key attribute -Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049 Signed-off-by: Shenoy, Nandan <[email protected]>
…k-api-enhancement Signed-off-by: Shenoy, Nandan <[email protected]>
…ment' of github.com:fidelity-contributions/camunda-camunda-bpm-platform into fidelity-contributions-feature/git-issue-4049-process-instance-pdk-api-enhancement
yanavasileva
added
ci:all-db
Runs the builds for all databases.
ci:default-build
Runs the builds that have no explicit trigger (e.g. different history levels).
ci:migration
Runs the process instance migration builds.
ci:rest-api
Runs extra builds for the REST API (currently only WLS compatibility builds).
ci:rolling-update
Runs the rolling update builds.
labels
Dec 11, 2024
yanavasileva
changed the title
CI: issue 4049 process instance pdk api enhancement
feat: process instance pdk api enhancement
Dec 12, 2024
To reviewer:
|
yanavasileva
commented
Dec 12, 2024
@@ -774,9 +783,13 @@ public void setProcessDefinition(ProcessDefinitionImpl processDefinition) { | |||
this.processDefinition = processDefinition; | |||
if (processDefinition != null) { | |||
this.processDefinitionId = processDefinition.getId(); | |||
if (processDefinition instanceof ProcessDefinitionEntity) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📓 Process definition can be created without a key. Therefore, setting the key only if we have have it.
Found out about the use case via failing org.camunda.bpm.engine.test.standalone.entity.EntitySerializationTest.testExecutionEntitySerialization()
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci:all-db
Runs the builds for all databases.
ci:default-build
Runs the builds that have no explicit trigger (e.g. different history levels).
ci:migration
Runs the process instance migration builds.
ci:rest-api
Runs extra builds for the REST API (currently only WLS compatibility builds).
ci:rolling-update
Runs the rolling update builds.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.