Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(sql): Test fix for incorrect running instances count in process … #4752

Merged
merged 2 commits into from
Jan 2, 2025
Merged

test(sql): Test fix for incorrect running instances count in process … #4752

merged 2 commits into from
Jan 2, 2025

Conversation

mboskamp
Copy link
Member

@mboskamp mboskamp commented Oct 30, 2024 •
edited by venetrius
Loading

Context: The query selectPDStatistics calculates the total processInstances wrong.
Used-by: ProcessDefinitionRestService#getStatisticsCount

Why: The group by incidentType part of the query should not be used for counting the total process instances.

Tests: The commit adds a test which expects the correct statistics returned when process instances related to incidents with different types are used.

Related-to: https://jira.camunda.com/browse/SUPPORT-24279
#4756

@mboskamp mboskamp added the ci:all-db Runs the builds for all databases. label Oct 30, 2024
@mboskamp mboskamp self-assigned this Oct 30, 2024
@mboskamp mboskamp mentioned this pull request Nov 1, 2024
Closed
1 task
@psavidis
Copy link
Contributor

psavidis commented Dec 18, 2024 •
edited
Loading

Reviewer Hints

Added a test which verifies the correctness of statistics for the issue reproduction case

  • The test fails when the fix commit is not effective (rolled-back, dropped etc)
  • The test passes when the fix is applied
  • The test passes against the CI (ref)
  • Merge PR

@psavidis psavidis added ci:webapp-integration Runs the webapp integration builds. and removed ci:all-db Runs the builds for all databases. labels Dec 18, 2024
@psavidis psavidis marked this pull request as ready for review December 18, 2024 20:12
@psavidis psavidis added ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:h2 Runs the builds for the H2 database. ci:run Runs the integration tests for the Run distribution. labels Dec 18, 2024
@psavidis psavidis assigned psavidis and unassigned mboskamp Dec 18, 2024
@psavidis psavidis requested a review from venetrius December 18, 2024 20:16
venetrius
venetrius approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@venetrius venetrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Verified that test would fail without the included query changes.
Really well written test case!

@psavidis psavidis merged commit 586037c into master Jan 2, 2025
14 of 15 checks passed
@psavidis psavidis deleted the SUPPORT-24279 branch January 2, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psavidis psavidis psavidis left review comments

@venetrius venetrius venetrius approved these changes

Assignees

@psavidis psavidis

Labels
ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:h2 Runs the builds for the H2 database. ci:run Runs the integration tests for the Run distribution. ci:webapp-integration Runs the webapp integration builds.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mboskamp @psavidis @venetrius