-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(license-book): update license book for 7.21.0 #4189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good.
❓ When do we add the source URL for the frontend libraries? Are they required for the end version of the license book? Some of them doesn't have or are incorrect here. E.g.: @bpmn-io/[email protected]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good. I noticed some special characters are not resolved correctly, but already approaving as I don't think that a problem with the final version of the book.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙃 improvements, the below character "issues" are present in the 7.20 book too:
- on row 67, there is some unrecognized characters - https://github.com/camunda/camunda-bpm-platform/blob/3830-update-7.21.0-license-book/distro/license-book/src/main/resources/license-book.txt#L67
(right is CI artifact, left is current file)
- on rows 714-717 special characters are not resolved - https://github.com/camunda/camunda-bpm-platform/blob/3830-update-7.21.0-license-book/distro/license-book/src/main/resources/license-book.txt#L714-L717
(right is CI artifact, left is current file) - same as above - https://github.com/camunda/camunda-bpm-platform/blob/3830-update-7.21.0-license-book/distro/license-book/src/main/resources/license-book.txt#L734-L743
(right is CI artifact, left is current file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to fix it. If I use the file directly from the CI, I see other character issues:
The problem might be that notice files were generated for different character sets, and either one or the other characters are broken depending on the current charset.
Since this is already broken with the last license book and the problems are minimal, I would tolerate them. Also, the characters on the left don't look 100 % correct. What's that =>
related to #3830