Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(license-book): update license book for 7.21.0 #4189

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

tasso94
Copy link
Member

@tasso94 tasso94 commented Mar 20, 2024

related to #3830

@tasso94 tasso94 requested a review from yanavasileva March 20, 2024 13:57
@tasso94 tasso94 self-assigned this Mar 20, 2024
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good.

❓ When do we add the source URL for the frontend libraries? Are they required for the end version of the license book? Some of them doesn't have or are incorrect here. E.g.: @bpmn-io/[email protected]

@tasso94
Copy link
Member Author

tasso94 commented Mar 21, 2024

What do you mean by source URL?
Do you mean repository URL? In case the maintainer of the library didn't add a repository URL to the package.json we cannot determine the repository URL automatically.

@tasso94 tasso94 requested a review from yanavasileva March 28, 2024 13:38
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. I noticed some special characters are not resolved correctly, but already approaving as I don't think that a problem with the final version of the book.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 improvements, the below character "issues" are present in the 7.20 book too:

image
(right is CI artifact, left is current file)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to fix it. If I use the file directly from the CI, I see other character issues:
image
The problem might be that notice files were generated for different character sets, and either one or the other characters are broken depending on the current charset.
Since this is already broken with the last license book and the problems are minimal, I would tolerate them. Also, the characters on the left don't look 100 % correct. What's that => image

@tasso94 tasso94 merged commit 3cd879a into master Mar 28, 2024
2 checks passed
@tasso94 tasso94 deleted the 3830-update-7.21.0-license-book branch March 28, 2024 19:00
brianwarner pushed a commit to fidelity-contributions/camunda-camunda-bpm-platform that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants