feat(engine): Introduce operation log for sync message correlations #4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
mboskamp
force-pushed
the
3900-sync-message-correlation-op-log
branch
3 times, most recently
from
13d739c to
c121942
Compare
mboskamp
commented
Jan 3, 2024
| if (variablesEnabled && execution != null) { | ||
|
|
||
| ProcessInstance processInstance = execution.getProcessInstance(); | ||
| resultWithVariables.setProcessInstance(processInstance); |
There was a problem hiding this comment.
Hint for the reviewer: This line is not directly associated with the feature but it is necessary to set the process instance for the message correlation, otherwise the operation log will not contain the process instance. I believe this was not implemented by mistake.
mboskamp
force-pushed
the
3900-sync-message-correlation-op-log
branch
3 times, most recently
from
066b4c0 to
b4382df
Compare
danielkelemen
approved these changes
Jan 17, 2024
engine/src/main/java/org/camunda/bpm/engine/impl/cfg/ProcessEngineConfigurationImpl.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/camunda/bpm/engine/impl/history/SynchronousOperationLogProducer.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/camunda/bpm/engine/impl/history/SynchronousOperationLogProducer.java
Outdated
Show resolved
Hide resolved
mboskamp
force-pushed
the
3900-sync-message-correlation-op-log
branch
from
b4382df to
5939769
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3900