Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github): reference reusable workflow correctly #3823

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

ThorbenLindhauer
Copy link
Member

related to #2781

@ThorbenLindhauer ThorbenLindhauer added ci:no-build Prevents any CI stage from running. bot:java-dependency-check When assigned to a PR, generates SBOMs for the PR and base branch and compares them. labels Oct 9, 2023
@ThorbenLindhauer ThorbenLindhauer self-assigned this Oct 9, 2023
@ThorbenLindhauer
Copy link
Member Author

Note that the workflow failed here because no SBOMs are generated (due to no changes in POM files). We could fix that and skip the SBOM diffing step in that case, but I think this is not the worth the effort right now.

@danielkelemen
Copy link
Member

Note that the workflow failed here because no SBOMs are generated (due to no changes in POM files). We could fix that and skip the SBOM diffing step in that case, but I think this is not the worth the effort right now.

Yes, it's not nice but it's alright. Maybe create a follow-up issue for that.

@ThorbenLindhauer ThorbenLindhauer merged commit ce47a45 into master Oct 9, 2023
3 of 4 checks passed
@ThorbenLindhauer ThorbenLindhauer deleted the 2781-workflow-reference branch October 9, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:java-dependency-check When assigned to a PR, generates SBOMs for the PR and base branch and compares them. ci:no-build Prevents any CI stage from running.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants