Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translation handler to webapps #4351

Closed
10 tasks done
tasso94 opened this issue May 15, 2024 · 3 comments
Closed
10 tasks done

Add translation handler to webapps #4351

tasso94 opened this issue May 15, 2024 · 3 comments
Assignees
@gbetances089
Labels
type:task Issues that are a change to the project that is neither a feature nor a bug fix. version:7.19.14 version:7.20.7 version:7.21.3 version:7.22.0-alpha3 version:7.22.0

Comments

@tasso94
Copy link
Member

tasso94 commented May 15, 2024 •
edited
Loading

Acceptance Criteria (Required on creation)

Add translation handler to webapps.

Hints

Links

Breakdown

Pull Requests
Preview Give feedback
  1. fix(webapps): add translation handler #4352
    bot:backport:7.19 bot:backport:7.20 bot:backport:7.21 ci:e2e ci:no-build
    tasso94

Dev2QA handover

  • Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment
@tasso94 tasso94 added type:task Issues that are a change to the project that is neither a feature nor a bug fix. version:7.22.0 potential:7.20.7 labels May 15, 2024
@tasso94
Copy link
Member Author

tasso94 commented May 15, 2024 •
edited
Loading

Handover Dev <-> QA

  • Please find an example custom frontend plugin to reproduce this in the linked SEC issue.
  • Please also do some regression testing for search widgets and pills and try out operators for variables like <, >, <=, >=.
  • Please test search widgets and pills on the standalone batch operation page.

tasso94 added a commit that referenced this issue May 15, 2024
@tasso94
fix(webapps): add translation handler
4bfccf5 
related to #4351
@tasso94 tasso94 mentioned this issue May 15, 2024
Merged
tasso94 added a commit that referenced this issue Jun 13, 2024
@tasso94
fix(webapps): add translation handler
cdd01c0 
related to #4351
@tasso94
Copy link
Member Author

tasso94 commented Jun 14, 2024

Hi @danielkelemen,

Please have another look at my latest changes:

  • I understood why cam-widget-search suffered from an endless loop in translating keys and fixed it.
    • This is because of fda59a6, which I reverted.
    • I added a reload for the batch operation page to fix this when changing the batch operation type.
    • I created a PR in the EE repo.
  • Also, I moved all search widget operators into the en.json files.
    • We don't need to add this to de.json since English is the fallback language.

Best,
Tassilo

@tasso94 tasso94 assigned danielkelemen and unassigned tasso94 Jun 14, 2024
@tasso94 tasso94 assigned danielkelemen and unassigned tasso94 Jun 18, 2024
tasso94 added a commit that referenced this issue Jun 20, 2024
@tasso94
fix(webapps): add translation handler
0a662c6 
- Fix translation loading problem on the batch operation page.
- Execute new handler on all translation keys.
- Add search pill comparison operators as proper translate strings.
- Add null-conditional operator to avoid errors

related to #4351
tasso94 added a commit that referenced this issue Jun 20, 2024
@tasso94
fix(webapps): add translation handler
fba860b 
- Fix translation loading problem on the batch operation page.
- Execute new handler on all translation keys.
- Add search pill comparison operators as proper translate strings.
- Add null-conditional operator to avoid errors

related to #4351
@tasso94 tasso94 assigned danielkelemen and unassigned tasso94 Jun 21, 2024
@tasso94 tasso94 assigned gbetances089 and unassigned tasso94 Jun 24, 2024
@gbetances089
Copy link
Member

Tested on camunda-bpm-ee-tomcat-7.21.3-ee and no regression was found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbetances089 gbetances089

Labels
type:task Issues that are a change to the project that is neither a feature nor a bug fix. version:7.19.14 version:7.20.7 version:7.21.3 version:7.22.0-alpha3 version:7.22.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gbetances089 @tasso94 @danielkelemen