Apply suggestions from code review

Co-authored-by: Miklas Boskamp <[email protected]>
camunda · Nov 27, 2023 · 95ae02c · 95ae02c
1 parent 8f1555e
commit 95ae02c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/engine/src/main/java/org/camunda/bpm/engine/externaltask/FetchAndLockBuilder.java b/engine/src/main/java/org/camunda/bpm/engine/externaltask/FetchAndLockBuilder.java
@@ -50,8 +50,7 @@ public interface FetchAndLockBuilder {
   /**
    * Configures the fetching during the Fetch and Lock Operation to include ordering by create time of the external tasks.
    * This method can be combined with asc() and desc() methods to define an ascending or descending order respectively.
-   * If no specific order is defined, the effective order will be desc as a sensible default since it will likely be
-   * more valuable to bring the most recently-created tasks first.
+   * If no specific order is defined, the effective order will be desc. The most recently created tasks are returned first.
    * To have explicit control, you can specify the order.
    *
    * @return the builder

diff --git a/engine/src/main/java/org/camunda/bpm/engine/impl/persistence/entity/ExternalTaskManager.java b/engine/src/main/java/org/camunda/bpm/engine/impl/persistence/entity/ExternalTaskManager.java
@@ -175,7 +175,7 @@ protected ListQueryParameterObject configureParameterizedQuery(Object parameter)
     return getTenantManager().configureQuery(parameter);
   }
 
-  protected boolean applyOrdering(boolean usePriority, boolean useCreateTime) {
+  protected boolean shouldApplyOrdering(boolean usePriority, boolean useCreateTime) {
     return usePriority || useCreateTime;
   }