fix(operate): use post request for decision definitions and decision instances endpoints #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. Can you open this against the |
…instances endpoints
huygur
force-pushed
the
use-post-request-for-decisions
branch
from
5a22ecb
to
419ae56
Compare
|
@jwulf done 👍 |
jwulf
reviewed
Sep 26, 2024
src/operate/lib/OperateDto.ts
Outdated
| @@ -40,6 +40,7 @@ export class DecisionInstance extends LosslessDto { | |||
| evaluationFailure!: string | |||
| @Int64String | |||
| processDefinitionKey!: string | |||
| processInstanceKey!: number | |||
There was a problem hiding this comment.
This should be a string, decorated with @Int64String.
Camunda 8 entity keys (such as processInstanceKey) are int64 in JSON and could be a value that cannot be accurately represented by the JS number type, so the Dtos enable lossless parsing with annotations - with the characteristic that C8 entity keys are strings in JS, rather than numbers.
There was a problem hiding this comment.
good to know. I was wondering why the keys were all strings when Operate API specified them as numbers
jwulf
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #262
DecisionInstance type should also include processInstanceKey, which is also addressed in this PR
Description of the change
[Describe your changes here]
Type of change
Checklist
alphabranchFurther comments
[If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...]