Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Link from top level 'incidents', 'jobs', and 'errors' to corresponding instance #452

Merged

Conversation

nitram509
Copy link
Collaborator

Motivation

this PR changes the navigation links, when one clicks on an instance in the incident view.
That helps because the user remains in the context (incident or job or error).

…to the instance's corresponding list view. this is a better navigation, because the user remains in the context (incident or job or error)
@CLAassistant
Copy link

CLAassistant commented Oct 3, 2022

CLA assistant check
All committers have signed the CLA.

@saig0 saig0 self-requested a review October 4, 2022 04:00
@saig0
Copy link
Contributor

saig0 commented Oct 4, 2022

@nitram509 thank you for your contribution. 🎉 I'll have a look at your PR in the next few days. 👀

Copy link
Contributor

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitram509 that is a nice improvement. I like it. 🎉

Your PR is ready to merge. 🚀


This pull request counts toward the Hacktoberfest challenge. If you contributed four pull requests then you can complete your Camunda Hacktoberfest challenge here.

@saig0 saig0 changed the title feat(ui) links from top level 'incidents', 'jobs', and 'errors' to corresponding instance feat: Link from top level 'incidents', 'jobs', and 'errors' to corresponding instance Oct 13, 2022
@saig0 saig0 merged commit b88f0cc into camunda-community-hub:main Oct 13, 2022
@nitram509 nitram509 deleted the feature/links-to-list-views branch December 11, 2022 14:39
@nitram509 nitram509 restored the feature/links-to-list-views branch February 15, 2023 13:59
@nitram509 nitram509 deleted the feature/links-to-list-views branch March 17, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants