-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(ui): service/cluster information and status page #369
feature(ui): service/cluster information and status page #369
Conversation
Unfortunately, I have to flag this as "WiP". Will try to find the root cause and report my findings. Please, keep in mind - I have no working JIB environment - as you have. |
[WARNING] Some problems were encountered while building the effective model for io.zeebe:zeebe-simple-monitor:jar:2.3.1-SNAPSHOT [WARNING] 'build.plugins.plugin.version' for org.springframework.boot:spring-boot-maven-plugin is missing. @ line 236, column 21
I did further testing and I'm glad to report that JIB correctly imports the I did verify, by running mvn -DskipTests package jib:dockerBuild and afterward, spin up a Docker Compose with the snapshot docker image. One comment I did add in the CONTRIBUTION.md |
Apologies for the inconvenience, but I oversaw a broken test. all fixed now. |
@saig0 I did fix the merge issue already :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nitram509 thank you for your contribution 🎉
First of all, you did a great job. The code looks good 👍
One small downside of the changes is that you may run into issues during local development. You documented it properly but you need to be aware of it. The only benefit is the build time which is not so important IMO. The version could be read also via Package object instead.
One bigger question for me is if the changes fit the project. The simple monitor aims to help developers during the modeling of the processes (i.e. monitoring and manual testing). But IMO the monitoring of the Zeebe cluster is a bit out of scope.
If the main concern is the question of whether Zeebe is available, then we could simplify the solution. For example, show a green or red bubble on the top/bottom of the page as an indication of the availability.
@nitram509 what do you think about it? Do you have a strong option regarding the page?
@saig0 thank you for your feedback - I'm glad you like it. Let me share some context of mine. I also requested a quote from Camunda and after some discussion with Sales, we concluded buying a license for Operate is not possible. Thus, the best alternative for us is to use Simple Monitor. So overall, this status page is way more than just a gimmick to us ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nitram509 thank you for sharing your throughs 👍 I appreciate it. And I see your point.
But I'm not convinced about adding DevOps as a user group for the Simple Monitor. There should be better tools for monitoring the services. For example, Grafana.
However, I'm fine with adding this status page. But I have some suggestions, please have a look.
For the next time, I recommend discussing new (major) features before. If you create an issue then we can discuss if it fits and what it could look like. So, you don't waste your time :)
src/main/java/io/zeebe/monitor/rest/ServiceStatusViewController.java
Outdated
Show resolved
Hide resolved
src/main/java/io/zeebe/monitor/rest/ServiceStatusViewController.java
Outdated
Show resolved
Hide resolved
src/main/java/io/zeebe/monitor/rest/ServiceStatusViewController.java
Outdated
Show resolved
Hide resolved
@nitram509 please note that I'm on vacation 🌴 I'll give feedback as soon as possible. |
enjoy the time :) |
@nitram509 any updates from your side? Are you still interested? Did you think about my previous comments? |
Hi, your ideas are good and I'm still interested. |
@nitram509 thanks for your update! Take your time 👍 |
@saig0 may I ask for a review, please? Just the version information was some pain in the a**. Any Feedback welcome. |
@nitram509 awesome. 🎉 I'll have a look at your PR in the next few days. 👀 |
@saig0 I've merged the latest changes from main and also fix two minor issues. Since we talked about ... what's your point of view regarding this PR? |
@nitram509 I'll have a look at your PR next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nitram509 it looks awesome. 🎉 👍
Hi,
during development, I found it useful, to check cluster version and status.
Knowing that this can be done per CLI, seeing this in Simple Monitor helps a lot as well.
This is a standard feature by Spring, which is just disabled by default.~~That said, technically this creates a
META-INF/build-info.properties
file, which needs to be present in the target"JAR" file OR it should be copied via the Maven "JIB" plugin into the target docker image.Do you know out of your head, if your (image) build pipeline does that?PS: The code is built robust, so that missing file/information will not crash the application's boot process.(see comments)
Next to the actual cluster information (see screenshot), there's a little switch, where anyone can update auto-refresh == automated page reload.
As usual, any feedback is welcome.