Added column size specification varchar(16000) to exporter SQL schema

[huksley]

Self-explanatory. The current version does not allow to load even the simple BPMN files to WORKFLOW table.

[Zelldon]

Hi @huksley ,

thanks for your contribution.

The current version does not allow to load even the simple BPMN files to WORKFLOW table.

I think we tested it with H2 and it seems to work, but maybe this is true for other databases. What type of database do you use?

What is the reason for 16000 as value?
Maybe it makes sense to use CLOB instead of VARCHAR what do you think?

Greets
Chris

[huksley]

H2 defaults to 255 symbols if not specified.
Usually BPMN processes are around 16k or less and split into different processes.
Unsure on using CLOB/TEXT because it can change application logic.

[Zelldon]

Hi @huksley ,

H2 defaults to 255 symbols if not specified.

I'm not sure if this is correct, since we have examples which are greater then 255 bytes anyhow
I think it makes sense to change this.

Usually BPMN processes are around 16k or less and split into different processes.

This is a bit vague, I mean why we say you can have only processes with maximal 16k bytes, not 17k or 18k? Would like to have an reason for this or no limit.

Unsure on using CLOB/TEXT because it can change application logic.

What do you mean with "it can change application logic"? You mean in the simple monitor?

Would like to have CLOB instead of VARCHAR, since this data type makes sense for larger values like the workflow models. Furthermore it is also ok if we change the current simple-monitor impl.

Would CLOB work for you? Which database do you use?

[huksley]

Hi I am using H2 and I have had an exception when uploading schema from simpe monitor that workflow.resource_ column can`t fit it due to column being 255 bytes.

After recreating table with resource_ varchar(16000) problem was fixed.

[huksley]

What do you mean with "it can change application logic"? You mean in the simple monitor?

CLOB datatype is not universally supported for example in MySQL/MariaDB it is named TEXT

[Zelldon]

Ok yes, but VARCHAR is not designed for this type of data (large texts). If the user wants to use another database, then he have to change it, maybe in the future we can also add an mechanism for auto detection.

The VARCHAR(16000) will also not work for oracle, since the max length is 4000 characters see here https://docs.oracle.com/cd/B28359_01/server.111/b28318/datatype.htm#CNCPT1822 or for ms sqlserver it is 8000, see here https://docs.microsoft.com/en-us/sql/t-sql/data-types/char-and-varchar-transact-sql?view=sql-server-2017 .

[huksley]

Superceeded by #39