Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exporter): export all record and value types by default #35

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

saig0
Copy link
Collaborator

@saig0 saig0 commented Mar 2, 2020

  • export all record/value types if no type is explicitly listed
  • all configuration entries can be overridden by environment variables with the same name in upper case

closes #27

@saig0 saig0 requested a review from Zelldon March 2, 2020 01:53
Copy link
Contributor

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍 just a small thing about the prefix. I'm not sure whether this could clash with the Hazelcast envs?

public class ExporterConfiguration {

public int port = 5701;
private static final String ENV_PREFIX = "HAZELCAST_";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might make to use ZEEBE_HAZELCAST as prefix to have no clash with Hazelcast ? 😅😀

* export all record/value types if no type is explicitly listed
* all configuration entries can be overridden by environment variables with the same name in upper case
@saig0 saig0 merged commit 03b0dd8 into master Mar 2, 2020
@saig0 saig0 deleted the config branch March 2, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export all records by default
2 participants