Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump hazelcast from 4.2.2 to 5.0.2 #155

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Conversation

saig0
Copy link
Collaborator

@saig0 saig0 commented Jan 3, 2022

Reopening dependabot PR #151.

@saig0 saig0 changed the title build(maven): dump hazelcast from 4.2.2 to 5.0.2 chore(deps): bump hazelcast from 4.2.2 to 5.0.2 Jan 3, 2022
@saig0 saig0 merged commit 19240b4 into master Jan 3, 2022
@saig0 saig0 deleted the hazelcast-5 branch January 3, 2022 13:30
@allanbarklie
Copy link

@saig0

Hi - just a note to say that I think the hazelcast upgrade brings in changed behaviour if running on K8s.
It now automatically adds the kubernetes auto discovery plugin which may need a little configuration to run correctly.
A likely error to see is something like java.lang.IllegalStateException: Unknown protocol: HTT

For now config can be done by adding env. variables in your k8s broker deployment of the form HAZELCAST_KUBERNETES_

Providing just:
HAZELCAST_KUBERNETES_SERVICE_NAME

or just the pair:
HAZELCAST_KUBERNETES_POD_LABEL_NAME
HAZELCAST_KUBERNETES_POD_LABEL_VALUE

should be enough to provide a quick fix.

See:
https://github.com/hazelcast/hazelcast-kubernetes/blob/master/src/main/java/com/hazelcast/kubernetes/KubernetesProperties.java
https://github.com/hazelcast/hazelcast-kubernetes
https://github.com/hazelcast/hazelcast/releases

@saig0
Copy link
Collaborator Author

saig0 commented Jan 28, 2022

@allanbarklie thank you for pointing this out 👍

Please let me know if we need to change or add something in the exporter.

@allanbarklie
Copy link

@saig0
One thing you might consider is adding pass through settings for the various service discovery options listed in https://github.com/hazelcast/hazelcast-kubernetes/blob/master/src/main/java/com/hazelcast/kubernetes/KubernetesProperties.java
or maybe just some info similar to the above notes in the readme so people know what to think about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants