fix: Roll back incompatible Protobuf version 4.x #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saig0
approved these changes
May 8, 2024
There was a problem hiding this comment.
@VonDerBeck thank you for fixing the compatibility issue. 🎉
Let's postpone the Protobuf update until Camunda is on the same version. 👍
I'll build a patch release after merging. 🏗️
saig0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks a lot for updating this exporter especially with the important UserTask events and all the other Zeebe 8.5 details. I really appreciate that 👍
Sadly the upgrade to google-protobuf version 4.x causes incompatibilities with the older 3.x version included in the current 8.5.1 versions of zeebe-client-java, zeebe-gateway-protocol-impl, etc. I get exceptions like
java.lang.NoClassDefFoundError: com/google/protobuf/GeneratedMessageV3Is there a specific reason to use the newer protobuf version? I think this should stay in sync with the major version used in all other parts of Zeebe.
If rolling back this dependency version is no option for you - is it possible to build a special protobuf-3.x version of the protobuf-exporter in parallel?
If you're fine with the changes: this PR just rolls back the protobuf library version to 3.x. and leaves everything else as required for Camunda 8.5. It would be great to publish this as version 1.6.1 of
zeebe-exporter-protobufcloses #366