feat: Add schema for new DMN records #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saig0
approved these changes
May 23, 2022
There was a problem hiding this comment.
@andrejpetras awesome 🎉 Thank you for your great contribution 🍰
I found two minor issues. I'll fix them and build a new release 🚀
| // given | ||
| final var recordValue = mockDecisionRecordValue(); | ||
| final Record<DecisionRecordValue> mockedRecord = | ||
| mockRecord(recordValue, ValueType.DECISION, ProcessEventIntent.TRIGGERING); |
There was a problem hiding this comment.
❌ We should use the DecisionIntent instead of the ProcessEventIntent.
| // then | ||
| assertMetadata(transformedRecord.getMetadata(), "DECISION_EVALUATION", "TRIGGERING"); | ||
|
|
||
| // List<EvaluatedDecisionValue> getEvaluatedDecisions(); |
There was a problem hiding this comment.
🔧 We could remove the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add schema for new DMN records.
closes #175