feature(cloudbuilder): Add UsePersistedStoragePath configuration to c… #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisKujawa
reviewed
Feb 1, 2024
Comment on lines
+80
to
+84
| if (path is null) | ||
| { | ||
| // use default | ||
| return this; | ||
| } |
There was a problem hiding this comment.
I would like to remove this, since we handle nulls here https://github.com/camunda-community-hub/zeebe-client-csharp/blob/main/Client/Impl/Builder/CamundaCloudTokenProviderBuilder.cs#L78-L83 and would like to fail if we put null in (likely by mistake, otherwise we would hide this and only realize later that we are not writing to the expected path)
|
I will merge it and do it afterwards. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #636