Feature/reorganize properties #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanlukas
requested review from
sbuettner and
chillleader
and removed request for
sbuettner
jonathanlukas
force-pushed
the
feature/reorganize-properties
branch
from
48e5e22 to
26cc146
Compare
chillleader
reviewed
Mar 11, 2024
...src/main/java/io/camunda/zeebe/spring/client/configuration/ExecutorServiceConfiguration.java
Outdated
Show resolved
Hide resolved
...r-camunda/src/main/java/io/camunda/zeebe/spring/client/properties/common/AuthProperties.java
Show resolved
Hide resolved
...camunda/src/main/java/io/camunda/zeebe/spring/client/properties/PropertiesPostProcessor.java
Show resolved
Hide resolved
chillleader
reviewed
Mar 11, 2024
chillleader
reviewed
Mar 11, 2024
...camunda/src/main/java/io/camunda/zeebe/spring/client/properties/CamundaClientProperties.java
Show resolved
Hide resolved
jonathanlukas
force-pushed
the
feature/reorganize-properties
branch
from
ee5a152 to
7330d7c
Compare
chillleader
approved these changes
Mar 19, 2024
jonathanlukas
added a commit
that referenced
this pull request
Mar 19, 2024
* deprecate old properties * refactoring usage of properties * wip * wip * wip * wip * legacy config still working * removed unused configuration * added backend issuer url to default saas props * adjusted readme * fixed broken test * functionality of new property strategy proved * moved from spring profiles to properties post processor * moved tests as well * worker overrides are applied over global overrides * typo * table format * add a general comment for first orientation * removed property * typo * updated docs about variable fetching * typo * update link to reflect new properties class * typo * deprecated classes * updated executorserviceconfig to reflect new properties * added a test to assert all deprecations are applied correctly * applied deprecation notices to all legacy properties * adjusted a reason comment (cherry picked from commit ef37537)
jonathanlukas
added a commit
that referenced
this pull request
Mar 22, 2024
* deprecate old properties * refactoring usage of properties * wip * wip * wip * wip * legacy config still working * removed unused configuration * added backend issuer url to default saas props * adjusted readme * fixed broken test * functionality of new property strategy proved * moved from spring profiles to properties post processor * moved tests as well * worker overrides are applied over global overrides * typo * table format * add a general comment for first orientation * removed property * typo * updated docs about variable fetching * typo * update link to reflect new properties class * typo * deprecated classes * updated executorserviceconfig to reflect new properties * added a test to assert all deprecations are applied correctly * applied deprecation notices to all legacy properties * adjusted a reason comment (cherry picked from commit ef37537)
chillleader
pushed a commit
that referenced
this pull request
Mar 22, 2024
* deprecate old properties * refactoring usage of properties * wip * wip * wip * wip * legacy config still working * removed unused configuration * added backend issuer url to default saas props * adjusted readme * fixed broken test * functionality of new property strategy proved * moved from spring profiles to properties post processor * moved tests as well * worker overrides are applied over global overrides * typo * table format * add a general comment for first orientation * removed property * typo * updated docs about variable fetching * typo * update link to reflect new properties class * typo * deprecated classes * updated executorserviceconfig to reflect new properties * added a test to assert all deprecations are applied correctly * applied deprecation notices to all legacy properties * adjusted a reason comment (cherry picked from commit ef37537)
jonathanlukas
added a commit
that referenced
this pull request
May 6, 2024
* deprecate old properties * refactoring usage of properties * wip * wip * wip * wip * legacy config still working * removed unused configuration * added backend issuer url to default saas props * adjusted readme * fixed broken test * functionality of new property strategy proved * moved from spring profiles to properties post processor * moved tests as well * worker overrides are applied over global overrides * typo * table format * add a general comment for first orientation * removed property * typo * updated docs about variable fetching * typo * update link to reflect new properties class * typo * deprecated classes * updated executorserviceconfig to reflect new properties * added a test to assert all deprecations are applied correctly * applied deprecation notices to all legacy properties * adjusted a reason comment (cherry picked from commit ef37537)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big property reorg happens here as the current status is a mess
closes #574
closes #456
closes #636
closes #602
closes #443