Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add timeout to ActivateJobs request #325

Merged
merged 37 commits into from
Sep 26, 2024
Merged

add timeout to ActivateJobs request #325

merged 37 commits into from
Sep 26, 2024

Conversation

EyalCMX
Copy link
Contributor

@EyalCMX EyalCMX commented Aug 25, 2022

add timeout to ActivateJobs request
handle ZeebeDeadlineExceeded exception

Changes

  • timeout to ActivateJobs request
  • handle ZeebeDeadlineExceeded exception

API Updates

New Features (required)

None

Deprecations (required)

None

Enhancements (optional)

fixing the issue describe below:
when using Camunda cloud zeebe, polling requests for activateJobs can stuck forever,
which leads to inability to consume more tasks

Checklist

  • Unit tests
  • Documentation

References

Fixes #324

@CLAassistant
Copy link

CLAassistant commented Aug 25, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JonatanMartens
Copy link
Collaborator

Hey @EyalCMX, looks good.

Please rebase from master so that tests can run and we can merge

@EyalCMX
Bump version: 3.0.4 → 3.0.5
1040e02
@EyalCMX
Bump version: 3.0.5 → 3.0.6
3116567
@EyalCMX
Bump version: 3.0.6 → 3.0.7
0f09810
@EyalCMX
Bump version: 3.0.7 → 3.0.8
7960e69
@EyalCMX
add logs
b053f8e
@EyalCMX
add last poll time var
daa7488
@EyalCMX
Bump version: 3.0.8 → 3.0.9
c5f86e3
@EyalCMX
fix import
129b7b0
@EyalCMX
Bump version: 3.0.9 → 3.0.10
e6d9c69
@EyalCMX
remove logs
69b331c
@EyalCMX
Bump version: 3.0.10 → 3.0.11
48f382e
@EyalCMX
Bump version: 3.0.11 → 3.0.12
9f051d2
@EyalCMX
Bump version: 3.0.12 → 3.0.13
16d16f5
@EyalCMX
Bump version: 3.0.13 → 3.0.14
7b369aa
@EyalCMX
Bump version: 3.0.14 → 3.0.15
790ba2c
@EyalCMX
add timeout and retry on grpc request
f858606 
handle grpc deadline exceeded exception
remove logs
@EyalCMX
Bump version: 3.0.15 → 3.0.16
6d653de
@EyalCMX
Bump version: 3.0.16 → 3.0.17
ad4d0c6
@EyalCMX
handle ZeebeDeadlineExceeded same as ZeebeInternalError
b40ebc5
@EyalCMX
Bump version: 3.0.17 → 3.0.18
71b9485
@EyalCMX
fix timeout param for grpc polling call
fc01b08 
add logs
@EyalCMX
Bump version: 3.0.18 → 3.0.19
324a887
@EyalCMX
remove logs
39314f8
@EyalCMX
remove unnecessary changes
c9697e0
@EyalCMX
fix format
33a3818
liorcmx
liorcmx approved these changes Nov 14, 2022
View reviewed changes
Copy link

@liorcmx liorcmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@EyalCMX
Copy link
Contributor Author

EyalCMX commented Nov 14, 2022

Hey @EyalCMX, looks good.

Please rebase from master so that tests can run and we can merge

@JonatanMartens done please approve!

@coveralls
Copy link

coveralls commented Nov 14, 2022 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 11057437142

Details

  • 6 of 8 (75.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 96.535%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyzeebe/grpc_internals/zeebe_adapter_base.py 2 3 66.67%
pyzeebe/worker/job_poller.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pyzeebe/worker/job_poller.py 1 83.33%
Totals Coverage Status
Change from base Build 11056680193: -0.08%
Covered Lines: 1003
Relevant Lines: 1039
💛 - Coveralls

@JonatanMartens
Copy link
Collaborator

@EyalCMX the job for format checking fails.
Please format using black: poetry run black ., push the changes and I'll approve

@EyalCMX
Copy link
Contributor Author

EyalCMX commented Nov 15, 2022

@EyalCMX the job for format checking fails. Please format using black: poetry run black ., push the changes and I'll approve

@JonatanMartens done please approve!

@EyalCMX
Copy link
Contributor Author

EyalCMX commented Jan 12, 2023

@JonatanMartens can u approve it again please

@EyalCMX
Copy link
Contributor Author

EyalCMX commented Jan 25, 2023

@JonatanMartens can u merge it i dont have permission

@michaelarnauts
Copy link

@EyalCMX @JonatanMartens i'm waiting for this to be merged. Is there a more maintained zeebe python plugin available?

@EyalCMX
Copy link
Contributor Author

EyalCMX commented Jan 15, 2024

@michaelarnauts i dont think @JonatanMartens maintains this library... and i can't merge it

@xomiamoore
Copy link
Contributor

Hey there @michaelarnauts @EyalCMX -- we're looking for additional maintainers for this project. #381

@JonatanMartens
Copy link
Collaborator

Hey @EyalCMX, I'm very sorry for the delayed review

@EyalCMX
Copy link
Contributor Author

EyalCMX commented May 7, 2024

@JonatanMartens ?

dimastbk
dimastbk reviewed Sep 26, 2024
View reviewed changes
pyzeebe/grpc_internals/zeebe_adapter_base.py Outdated Show resolved Hide resolved
pyzeebe/grpc_internals/zeebe_job_adapter.py Outdated Show resolved Hide resolved
pyzeebe/worker/job_poller.py Outdated Show resolved Hide resolved
@dimastbk dimastbk merged commit bed8bf6 into camunda-community-hub:master Sep 26, 2024
17 checks passed
@liorcmx
Copy link

liorcmx commented Sep 29, 2024

@EyalCMX , congrats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonatanMartens JonatanMartens JonatanMartens approved these changes

@dimastbk dimastbk dimastbk left review comments

@liorcmx liorcmx liorcmx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

when using Camunda cloud zeebe, polling requests for activateJobs stuck forever
8 participants
@EyalCMX @CLAassistant @JonatanMartens @coveralls @michaelarnauts @xomiamoore @liorcmx @dimastbk