Switch from p.types/definterface+ to defprotocol #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 86.06% 87.65% +1.59%
==========================================
Files 22 22
Lines 1177 1175 -2
Branches 72 67 -5
==========================================
+ Hits 1013 1030 +17
+ Misses 92 78 -14
+ Partials 72 67 -5
Continue to review full report at Codecov.
|
Open
camsaul
added
the
clojurescript support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For eventual ClojureScript support. The interface is pretty stable at this point so the benefits of
definterface+aren't as important. Also Potemkindefinterface+ends up generating uncovered code which is affecting our Cloverage coverage numbers a bit.