Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zone picking list zones on start #89

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Zone picking list zones on start #89

merged 3 commits into from
Oct 22, 2020

Conversation

simahawk
Copy link
Member

@simahawk simahawk commented Sep 30, 2020 •
edited
Loading

TODO

  • add test for select zone data

ref: 1434

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2020 •
edited
Loading

Codecov Report

Merging #89 into 13.0-shopfloor will increase coverage by 1.63%.
The diff coverage is 88.37%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           13.0-shopfloor      #89      +/-   ##
==================================================
+ Coverage           91.06%   92.69%   +1.63%     
==================================================
  Files                  55       55              
  Lines                3972     4027      +55     
==================================================
+ Hits                 3617     3733     +116     
+ Misses                355      294      -61
Impacted Files Coverage Δ
shopfloor/services/zone_picking.py 95.65% <88.37%> (+0.34%) ⬆️
shopfloor/models/stock_picking.py 95.45% <0.00%> (-4.55%) ⬇️
shopfloor/models/stock_location.py 100.00% <0.00%> (ø)
shopfloor/actions/message.py 92.00% <0.00%> (+2.66%) ⬆️
shopfloor/services/delivery.py 95.47% <0.00%> (+17.69%) ⬆️
shopfloor/services/scan_anything.py 100.00% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e07718...4ea79fc. Read the comment docs.

sebalix
sebalix reviewed Sep 30, 2020
View reviewed changes
Copy link
Member

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question and one comment

shopfloor/tests/test_zone_picking_start.py Outdated Show resolved Hide resolved
shopfloor/services/zone_picking.py Show resolved Hide resolved
@simahawk simahawk force-pushed the zone-picking-list-zones branch from e4fd1fa to 4ea79fc Compare October 5, 2020 10:17
@simahawk simahawk force-pushed the zone-picking-list-zones branch from 4ea79fc to 504b290 Compare October 19, 2020 09:03
@simahawk
Copy link
Member Author

@sebalix @guewen can you pass here again?

@simahawk
shopfloor_mobile: fix odoo data handling for aliased states
265206e 
'start' is an alias for the initial state.
If we load that at init we must pick initial state data
from the right key. The key could be 'start' or the real state name.
Better to use always the next_state key to access data from the server.
@simahawk
zone_picking: list all zones on start
390b1a4 
When the operator starts with zone picking scenario
the 1st screen presents the list of zones
that have lines to process.
@simahawk simahawk force-pushed the zone-picking-list-zones branch from 504b290 to 390b1a4 Compare October 22, 2020 06:24
@simahawk simahawk merged commit bae61d1 into camptocamp:13.0-shopfloor Oct 22, 2020
simahawk added a commit that referenced this pull request Dec 3, 2020
@simahawk
Merge pull request #89 from simahawk/13-shopfloor-misc-fixes
5dae712 
Shopfloor: misc fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebalix sebalix sebalix approved these changes

@guewen guewen guewen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simahawk @codecov-commenter @guewen @sebalix