Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shopfloor_mobile: REF index to render app w/ qweb template #82

Merged
merged 3 commits into from
Sep 24, 2020
Merged

shopfloor_mobile: REF index to render app w/ qweb template #82

merged 3 commits into from
Sep 24, 2020

Conversation

simahawk
Copy link
Member

@simahawk simahawk commented Sep 21, 2020 •
edited
Loading

Features:

  • makes the app odoo-like extendible
  • use module version to force reload of resources changing URL
  • added icons (to be improved)
  • display module version in the app

Ref: 1451

@simahawk
shopfloor_mobile: REF index to render app w/ qweb template
3a55deb 
Features:

* makes the app odoo-like extendible
* use module version to force reload of resources changing URL
* make possible to display module version
* added icons (to be improved)
* display module version in the app
@simahawk simahawk mentioned this pull request Sep 21, 2020
Merged
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2020 •
edited
Loading

Codecov Report

Merging #82 into 13.0-shopfloor will decrease coverage by 0.42%.
The diff coverage is 31.42%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           13.0-shopfloor      #82      +/-   ##
==================================================
- Coverage           91.98%   91.55%   -0.43%     
==================================================
  Files                  54       55       +1     
  Lines                3867     4216     +349     
==================================================
+ Hits                 3557     3860     +303     
- Misses                310      356      +46
Impacted Files Coverage Δ
shopfloor_mobile/controllers/main.py 33.33% <31.42%> (-16.67%) ⬇️
shopfloor/models/stock_package_level.py 92.00% <0.00%> (-1.75%) ⬇️
...pfloor/actions/location_content_transfer_sorter.py 100.00% <0.00%> (ø)
shopfloor/models/priority_postpone_mixin.py 93.75% <0.00%> (ø)
shopfloor/actions/message.py 89.33% <0.00%> (+0.14%) ⬆️
shopfloor/services/location_content_transfer.py 98.34% <0.00%> (+0.67%) ⬆️
shopfloor/models/stock_move_line.py 98.83% <0.00%> (+2.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 293a97b...6788e8f. Read the comment docs.

sebalix
sebalix reviewed Sep 22, 2020
View reviewed changes
shopfloor_mobile/templates/assets.xml Outdated Show resolved Hide resolved
shopfloor_mobile/templates/assets.xml Outdated Show resolved Hide resolved
@simahawk
Copy link
Member Author

@sebalix cleaned up external resources.

sebalix
sebalix approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@simahawk simahawk merged commit bcdb627 into 13.0-shopfloor Sep 24, 2020
guewen pushed a commit that referenced this pull request Dec 2, 2020
@OCA-git-bot
Merge PR #82 into 13.0
6d4e1eb 
Signed-off-by simahawk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebalix sebalix sebalix approved these changes

@guewen guewen guewen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simahawk @codecov-commenter @guewen @sebalix