new method to validate moves in a separate transfer #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebalix
force-pushed
the
13.0-shopfloor-action_done_in_picking
branch
from
b81b880 to
65409b0
Compare
sebalix
changed the title
sebalix
commented
Sep 16, 2020
sebalix
commented
Sep 16, 2020
guewen
reviewed
Sep 16, 2020
sebalix
force-pushed
the
13.0-shopfloor-action_done_in_picking
branch
4 times, most recently
from
3397ddb to
4aafbf2
Compare
sebalix
commented
Sep 16, 2020
guewen
reviewed
Sep 17, 2020
sebalix
force-pushed
the
13.0-shopfloor-action_done_in_picking
branch
from
ba3939b to
6100ed0
Compare
|
Rebased to get a green build |
Codecov Report
@@ Coverage Diff @@
## 13.0-shopfloor #72 +/- ##
==================================================
+ Coverage 91.95% 91.96% +0.01%
==================================================
Files 54 54
Lines 3866 3884 +18
==================================================
+ Hits 3555 3572 +17
- Misses 311 312 +1
Continue to review full report at Codecov.
|
|
|
guewen
approved these changes
Sep 17, 2020
4 tasks
simahawk
pushed a commit
to simahawk/wms
that referenced
this pull request
Oct 12, 2020
Calling _action_done() directly on the stock.move while leaving the stock.picking "assigned" with the other moves already required various workarounds as it is normally not an expected flow in Odoo. This method is to be used in services instead of calling _action_done() on the moves. If a move to set to done contains move lines that should not be validated, the line to keep should be extracted beforehand with `move_id.split_other_move_lines`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.