shopfloor: ensure that confirmation email is sent when moves are validated #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebalix
force-pushed
the
13.0-shopfloor-1215
branch
from
012496a to
f4b058e
Compare
|
I'd not have taken this approach that needs to pass a context key: almost sure we'll forget to do it on new calls to |
guewen
reviewed
Aug 27, 2020
| @@ -207,7 +207,8 @@ def _set_destination_and_done(self, move, scanned_location): | |||
| # when writing the destination on the package level, it writes | |||
| # on the move lines | |||
| move.move_line_ids.package_level_id.location_dest_id = scanned_location | |||
| move._action_done() | |||
| # FIXME: '_sf_no_backorder' was not passed in the context, is it expected? | |||
There was a problem hiding this comment.
Perhaps. Maybe. I don't know.
Originally, this scenario was meant to move a picking with a single package, the behavior for other uses cases are undefined (to my knowledge).
|
I'll do as you suggest, it's safer. |
|
@guewen New approach pushed as fixup |
guewen
reviewed
Aug 27, 2020
guewen
approved these changes
Aug 27, 2020
simahawk
pushed a commit
to simahawk/wms
that referenced
this pull request
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I let some FIXME in the code regarding the existing calls to
move._action_donewithout the_sf_no_backordercontext key, I don't know if it was what we wanted when this code has been written or if it needs to be updated/fixed now?Issue 1215
ping @guewen