Misc fix / imp #49
Merged
Misc fix / imp #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* store full traceback in log entry * return log entry URL to ease reporting
When the backend raises an exception, can provide a log entry URL. It's now displayed in the notification message.
guewen
reviewed
Aug 26, 2020
| def _constrain_name_unique(self): | ||
| for rec in self: | ||
| if self.search_count([("name", "=", rec.name), ("id", "!=", rec.id)]): | ||
| raise exceptions.UserError(_("Package name must be unique!")) |
There was a problem hiding this comment.
I prefer not to go for it to avoid conflicts w/ setup data and especially tests.
Also, if for any reason you want to take control of the feature, you can do it in this way.
guewen
reviewed
Aug 26, 2020
|
|
||
| log_entry = self._log_call_in_db(self.env, request, _id, params, result=result) | ||
| log_entry_url = self._get_log_entry_url(log_entry) | ||
| result["log_entry_url"] = log_entry_url |
Closed
guewen
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits are self-explanatory.
Major change: exceptions on dispatch now return the log entry URL to improve reporting + check pkg name is unique.
Requires OCA/rest-framework#76 to be fully functional (not broken w/out tho).