Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fixes for zone picking #42

Merged
merged 3 commits into from
Aug 21, 2020
Merged

Misc fixes for zone picking #42

merged 3 commits into from
Aug 21, 2020

Conversation

simahawk
Copy link
Member

@simahawk simahawk commented Aug 20, 2020 •
edited
Loading

  1. fix issue w/ pkg qty widget w/out unique key for pkgs
  2. change validation for partial picking: a package is now required
  • front: change the scan widget message
  • back: send back to same screen and show "package not found" message
  1. fix issue w/ qty handling on set line destination reload (qty was lost due to pt 2)

@simahawk simahawk requested review from sebalix and guewen August 20, 2020 10:44
sebalix
sebalix requested changes Aug 20, 2020
View reviewed changes
shopfloor/services/zone_picking.py Outdated Show resolved Hide resolved
sebalix
sebalix approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure to understand the change, but I suppose it is what we want :p

@simahawk
Copy link
Member Author

Not sure to understand the change, but I suppose it is what we want :p

updated the description to explain what we wanted 😉

@simahawk
bknd: fix zone_picking handling of set destination
af8a5b6 
* if qty is partial -> accept only packages as destination
* fix message when nothing has been processed (no location and no pkg)
@simahawk
zone_picking: handle case where set line dest has no line
7b9dd20
@simahawk
front: zone_picking + loc transfer fix qty handling on set dest
ea7cd5f 
Usecase:

1. set_line_destination is loaded -> the init dest qty is stored by `on_qty_update`
2. set a new qty via picker -> the dest qty is stored by `on_qty_update`
3. scan a wrong pack -> the state is reloaded, the qty stored is flushed, `on_qty_update` is not called
because the picker widget is not re-rendered.

By storing it in the component data, the value is preserved.
@simahawk
Copy link
Member Author

@guewen fixed and squashed. Thanks!

@simahawk simahawk merged commit ab2753e into camptocamp:13.0-shopfloor Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebalix sebalix sebalix approved these changes

@guewen guewen guewen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simahawk @guewen @sebalix