Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

location transfer: fix issue if move lines have different src locations #40

Merged
merged 2 commits into from
Aug 17, 2020
Merged

location transfer: fix issue if move lines have different src locations #40

merged 2 commits into from
Aug 17, 2020

Conversation

sebalix
Copy link
Member

@sebalix sebalix commented Aug 17, 2020 •
edited
Loading

  • the first commit add a test to reproduce the issue (which has to fail)
  • the second commit fix the situation

Ticket 1362

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2020 •
edited
Loading

Codecov Report

Merging #40 into 13.0-shopfloor will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           13.0-shopfloor      #40   +/-   ##
===============================================
  Coverage           92.17%   92.18%           
===============================================
  Files                  51       51           
  Lines                3656     3658    +2     
===============================================
+ Hits                 3370     3372    +2     
  Misses                286      286
Impacted Files Coverage Δ
shopfloor/services/location_content_transfer.py 97.59% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a78b325...08d7a43. Read the comment docs.

@sebalix sebalix force-pushed the 13.0-shopfloor-issue-1362 branch from 4e2a305 to ec125f8 Compare August 17, 2020 13:35
jgrandguillaume
jgrandguillaume approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgrandguillaume jgrandguillaume merged commit 03ff9c0 into camptocamp:13.0-shopfloor Aug 17, 2020
TDu pushed a commit to TDu/wms that referenced this pull request Sep 1, 2020
@OCA-git-bot
Merge PR camptocamp#40 into 13.0
46013a4 
Signed-off-by guewen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgrandguillaume jgrandguillaume jgrandguillaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebalix @codecov-commenter @jgrandguillaume