Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Fix getFeaturesFromIds when GMF and WMS layers do not have the … #5553

Merged
merged 1 commit into from
May 28, 2020

Conversation

arnaud-morvan
Copy link
Member

@arnaud-morvan arnaud-morvan commented Feb 21, 2020

…same name

Need to be ported in master

api/src/Querent.js Outdated Show resolved Hide resolved
@arnaud-morvan arnaud-morvan force-pushed the fix_api_getFeaturesFromIds branch 2 times, most recently from 901c864 to 3abd509 Compare May 28, 2020 14:11
api/index.js Outdated Show resolved Hide resolved
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, that looks good :-)

api/src/Querent.js Outdated Show resolved Hide resolved
@arnaud-morvan arnaud-morvan force-pushed the fix_api_getFeaturesFromIds branch 2 times, most recently from 12a76d6 to 1a38265 Compare May 28, 2020 14:45
api/src/Querent.js Outdated Show resolved Hide resolved
For GMF layers with multiple child layers.
@arnaud-morvan arnaud-morvan force-pushed the fix_api_getFeaturesFromIds branch from 1a38265 to 4bca5a9 Compare May 28, 2020 15:16
@sbrunner
Copy link
Member

Nice :-)

@arnaud-morvan
Copy link
Member Author

Thanks @sbrunner

@arnaud-morvan arnaud-morvan merged commit 58ed28a into 2.4 May 28, 2020
@arnaud-morvan arnaud-morvan deleted the fix_api_getFeaturesFromIds branch May 28, 2020 15:36
@c2c-bot-gis-ci
Copy link
Collaborator

Error on backporting to branch 2.5, see Docker Hub actions for more information.

@c2c-bot-gis-ci
Copy link
Collaborator

Error on backporting to branch master, see Docker Hub actions for more information.

@sbrunner
Copy link
Member

@arnaud-morvan do you see that the backports failed?

@arnaud-morvan
Copy link
Member Author

Yes, already opened backport PRs. Master one is failing, but is it master branch which is broken.

@arnaud-morvan
Copy link
Member Author

Sorry, master one is green now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants