Additional search actions #5355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
reviewed
Dec 9, 2019
sbrunner
reviewed
Dec 10, 2019
|
Thanks for the review. I fixed your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @sbrunner we from Basel-Stadt are creating a pull request to get this additional gmf functionality within our project.
Our aim is to include tools to the search so a user can search for a tool and with a click on the search result the tool will be opened. The implementation in our project can be found here: https://github.com/camptocamp/baselstadt_mapbs/commit/a2d95c78976a8fa30d4ecb47c71699429ac3e18e
How do we have to proceed to get this to GMF 2.5 as base functionality for futher versions?