Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify file input in import datasource component #5021

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Conversation

fredj
Copy link
Member

@fredj fredj commented Jul 16, 2019

@fredj fredj force-pushed the simplify_file_input branch from 3632cef to 9b8b43a Compare July 16, 2019 08:43
@fredj fredj force-pushed the simplify_file_input branch from 9b8b43a to 2109939 Compare July 16, 2019 08:44
@sbrunner sbrunner changed the title Simplify file input in import datasource component [WIP] Simplify file input in import datasource component Jul 16, 2019
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we should add a title for "long" file names

@fredj
Copy link
Member Author

fredj commented Jul 16, 2019

I've checked and the title is automatically displayed

@fredj fredj changed the title [WIP] Simplify file input in import datasource component Simplify file input in import datasource component Jul 16, 2019
@fredj fredj merged commit 388a5a9 into master Jul 16, 2019
@fredj fredj deleted the simplify_file_input branch July 16, 2019 13:48
@sbrunner sbrunner added this to the 2.5 milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants