Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS caching issue #4763

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Fix CSS caching issue #4763

merged 1 commit into from
Mar 21, 2019

Conversation

gberaudo
Copy link
Member

When the only changes are HTML or CSS the hash was not updated.
This commit should fix the issue.

@gberaudo gberaudo requested a review from sbrunner March 21, 2019 08:49
@gberaudo gberaudo force-pushed the fix_css_caching_issues branch from 6edd9c3 to 047396e Compare March 21, 2019 09:08
When the only changes are HTML or CSS the hash was not updated.
This commit should fix the issue.

For why hash is used instead of contenthash, see webpack-contrib/extract-text-webpack-plugin#763 (comment).
@gberaudo gberaudo force-pushed the fix_css_caching_issues branch from 047396e to fb5a184 Compare March 21, 2019 09:26
@gberaudo gberaudo merged commit 74986fe into 2.3 Mar 21, 2019
@gberaudo gberaudo deleted the fix_css_caching_issues branch March 21, 2019 09:58
@sbrunner sbrunner added this to the 2.3 milestone Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants