Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix geolocation error function binding #4277

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Fix geolocation error function binding #4277

merged 1 commit into from
Oct 1, 2018

Conversation

fredj
Copy link
Member

@fredj fredj commented Oct 1, 2018

ger-benjamin
ger-benjamin approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@fredj fredj force-pushed the geolocation_error_bind branch from 4da0464 to c23ab1d Compare October 1, 2018 06:56
@fredj fredj merged commit a1210ea into 2.3 Oct 1, 2018
@fredj fredj deleted the geolocation_error_bind branch October 1, 2018 08:36
@sbrunner sbrunner added this to the 2.1 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ger-benjamin ger-benjamin ger-benjamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@fredj @ger-benjamin @sbrunner