Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show login form when restricted layers in permalink #4256

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Show login form when restricted layers in permalink #4256

merged 1 commit into from
Sep 28, 2018

Conversation

arnaud-morvan
Copy link
Member

@arnaud-morvan arnaud-morvan commented Sep 20, 2018 •
edited by sbrunner
Loading

@arnaud-morvan
Copy link
Member Author

@sbrunner @ger-benjamin : Could someone have a first look and give a some feedback about what I'm doing here.

@arnaud-morvan arnaud-morvan force-pushed the permalink_private_layers branch 2 times, most recently from 437fe1b to 8dfea68 Compare September 27, 2018 09:33
@sbrunner
Copy link
Member

Tested with this URL and I get a javascript error when I'm not loggin...
https://camptocamp.github.io/ngeo/permalink_private_layers/examples/contribs/gmf/apps/desktop_alt.html?map_x=638239&map_y=178692&map_zoom=3&lang=fr&baselayer_ref=OSM%20map&theme=Transport&tree_group_layers_Paysage=accommodation%2Ctourism_activity%2Cinformation&tree_groups=OSM%20functions%20mixed%2CLayers%2CGroup%2COSM%20functions%2CExternal%2CFilters%20mixed%2CFilters&tree_group_layers_Transport=fuel&tree_group_opacity_Group=0.65&tree_enable_osm_scale=false&tree_enable_osm_open=false&tree_enable_Layer%20with%20very%20very%20very%20very%20very%20long%20name=false&tree_enable_osm_time_r_s=false&tree_enable_osm_time_v_s=false&tree_enable_osm_time_v_dp=false&tree_enable_osm_time_r_dp=false&tree_enable_osm_time_r_year_mounth=false&tree_enable_osm_time_d_year_mounth=false&tree_enable_osm_time_r_mounth_year=false&tree_enable_osm_time_v_mounth_year=false&tree_enable_long%20wms-t%20layer%20name%20name%20name%20name%20name%20name%20name=false&tree_enable_two_layers=false&tree_enable_ch.astra.ausnahmetransportrouten=false&tree_enable_no_wfs=false&tree_enable_ch.are.alpenkonvention=false&tree_group_layers_Layers=&tree_group_layers_Group=osm&tree_group_layers_OSM%20functions=

@sbrunner
Copy link
Member

A digest error :-/

@arnaud-morvan arnaud-morvan force-pushed the permalink_private_layers branch 2 times, most recently from be9b930 to 72dfa11 Compare September 27, 2018 11:56
@arnaud-morvan
Copy link
Member Author

I'm not completely aware with digest loops.
But it should be better now as permalink service send only one event, and this is a anglular event we do not call digest manually anymore.

sbrunner
sbrunner approved these changes Sep 27, 2018
View reviewed changes
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)

@arnaud-morvan arnaud-morvan force-pushed the permalink_private_layers branch from 72dfa11 to a14aa04 Compare September 27, 2018 13:32
@arnaud-morvan arnaud-morvan merged commit 6248d89 into 2.3 Sep 28, 2018
@arnaud-morvan arnaud-morvan deleted the permalink_private_layers branch September 28, 2018 08:23
@sbrunner sbrunner added this to the 2.3 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@arnaud-morvan @sbrunner