Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GoogleStreetView from desktop app #4255

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Remove GoogleStreetView from desktop app #4255

merged 1 commit into from
Sep 27, 2018

Conversation

arnaud-morvan
Copy link
Member

@arnaud-morvan arnaud-morvan commented Sep 20, 2018 •
edited
Loading

sbrunner
sbrunner reviewed Sep 20, 2018
View reviewed changes
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be discus but finally I'm not sure that we want streetview on desktop application, probably it should be only on desktop_alt, and properly cleaned on desktop application...

@arnaud-morvan
Copy link
Member Author

+1, in my case, I've removed it from aeroportsdelyon_sig

@arnaud-morvan
Copy link
Member Author

In such case do we still need :

ngeo/contribs/gmf/apps/desktop/index.html.ejs

Line 322 in 453c721

<script src="https://maps.googleapis.com/maps/api/js?v=3&key=AIzaSyCYnqxEQA5sz13sWSgMr97ejzvUeGP8gz4"></script>

@fredj
Copy link
Member

fredj commented Sep 20, 2018

+1 to have it only in desktop_alt

@arnaud-morvan arnaud-morvan force-pushed the openstreetview_dependency branch from 2985139 to 51e4c35 Compare September 27, 2018 08:56
@arnaud-morvan arnaud-morvan changed the title Add ngeoGooglestreetviewModule dependency in desktop Remove GoogleStreetView from desktop app Sep 27, 2018
@arnaud-morvan
Copy link
Member Author

I've removed GoogleStreetView from desktop app. Ready for review now.

@arnaud-morvan arnaud-morvan merged commit 6308e5b into 2.3 Sep 27, 2018
@arnaud-morvan arnaud-morvan deleted the openstreetview_dependency branch September 27, 2018 11:17
@sbrunner sbrunner added this to the 2.3 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

@fredj fredj fredj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@arnaud-morvan @fredj @sbrunner