Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document $injector usage #3999

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Document $injector usage #3999

merged 1 commit into from
Jul 2, 2018

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Jul 2, 2018

fix #1865

@sbrunner sbrunner added this to the 2.3 milestone Jul 2, 2018
@sbrunner sbrunner requested a review from gberaudo July 2, 2018 09:56
@sbrunner sbrunner changed the title Document usage Document $injector usage Jul 2, 2018
gberaudo
gberaudo approved these changes Jul 2, 2018
View reviewed changes
docs/guidelines.md Outdated
@@ -150,6 +150,11 @@ const myComponent = {
};
```

## `$injector` usage

`$injector` should be use only for the optional requirements.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used

docs/guidelines.md Outdated
## `$injector` usage

`$injector` should be use only for the optional requirements.
The only exception is for the abstract controllers (in `gmf/controleurs`) for upgrade facilities.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to ease upgrade.

@sbrunner sbrunner merged commit c70d5c7 into 2.3 Jul 2, 2018
@sbrunner sbrunner deleted the doc branch July 2, 2018 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gberaudo gberaudo gberaudo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @gberaudo