Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modal in GMF share example #3906

Merged
merged 1 commit into from
May 23, 2018
Merged

Fix modal in GMF share example #3906

merged 1 commit into from
May 23, 2018

Conversation

llienher
Copy link
Member

This PR fixes the GMF example with the ng-if...

@llienher llienher added this to the 2.3 milestone May 23, 2018
@llienher llienher self-assigned this May 23, 2018
@llienher llienher requested review from sbrunner and gberaudo May 23, 2018 12:16
@llienher llienher merged commit c892a78 into 2.3 May 23, 2018
@llienher llienher deleted the fix_share_example branch May 23, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gberaudo gberaudo gberaudo approved these changes

@sbrunner sbrunner Awaiting requested review from sbrunner

Assignees

@llienher llienher

Labels
None yet
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@llienher @gberaudo