Follow up fix datepicker #3901
Merged
Follow up fix datepicker #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
reviewed
May 23, 2018
src/filter/ruleComponent.js
Outdated
| @@ -227,12 +227,12 @@ exports.RuleController_ = class { | |||
| * @export | |||
| */ | |||
| this.timeRangeMode = { | |||
| widget: /** @type {ngeox.TimePropertyWidgetEnum} */ ('datepicker'), | |||
| maxValue: this.createDate_(), | |||
| minValue: this.createWeekAgoDate_(), | |||
There was a problem hiding this comment.
For me it should be used as def values ...
sbrunner
reviewed
May 23, 2018
| @@ -424,24 +424,21 @@ exports.RuleController_ = class { | |||
| this.unlisteners_.push(this.scope_.$watch( | |||
| () => this.clone.getExpression(), | |||
| (newVal) => { | |||
| const value = newVal === null ? this.createDate_() : newVal; | |||
| this.timeValueMode.minValue = value; | |||
| this.timeValueMode.minValue = newVal; | |||
There was a problem hiding this comment.
Not idea.
But since we now handle the null value correctly I suppose the ternary operation can be removed.
gberaudo
force-pushed
the
follow_up_fix_datepicker_GSGMF-462
branch
from
68a120f to
eb9460d
Compare
…stanbul-reporter-2.0.1 Update karma-coverage-istanbul-reporter to the latest version 🚀
Add missing ng-if for share popup in desktop interface
gberaudo
force-pushed
the
follow_up_fix_datepicker_GSGMF-462
branch
from
eb9460d to
6f98e0c
Compare
gberaudo
force-pushed
the
follow_up_fix_datepicker_GSGMF-462
branch
from
6f98e0c to
69352e9
Compare
|
@sbrunner I fixed the issue with Travis. |
sbrunner
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3899.
With this PR, the datepicker selection is: